Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique: Add conversion constructors and tests #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unique: Add conversion constructors and tests #60

wants to merge 1 commit into from
+123 −3

Conversation

ArsenArsen
Copy link
Member

No description provided.

no92
no92 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArsenArsen
Copy link
Member Author

before merging, I'd like to know if anyone can think of any other test cases to add

Dennisbonke
Dennisbonke approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qookei
qookei reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I have a small nitpick. The new code uses left-sided pointers and references instead of right-sided ones (T& x vs T &x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qookei qookei qookei left review comments

@Dennisbonke Dennisbonke Dennisbonke approved these changes

@no92 no92 no92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArsenArsen @no92 @Dennisbonke @qookei